Skip to content

[RFC-0014] Upgrade auth - #1776

Merged
matheuscscp merged 1 commit into
mainfrom
rfc-0014-move-to-apis-crypto
Oct 22, 2026
Merged

matheuscscp merged 1 commit into
mainfrom
rfc-0014-move-to-apis-crypto

Conversation

@matheuscscp

@matheuscscp matheuscscp commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Part of: fluxcd/flux2#6103

No new features yet, just migrating to pkg/auth with pkg/apis/crypto/v1.

@matheuscscp matheuscscp added enhancement New feature or request area/security Security related issues and pull requests area/rfc labels Oct 19, 2026
Comment thread api/v1/metrics.go
MetricDecryptWithVault = "decrypt_with_vault"
// MetricDecryptWithTransitEngine is the metric name for counting
// decryption attempts using OpenBao/Vault's transit engine.
MetricDecryptWithTransitEngine = "decrypt_with_transit_engine"

@matheuscscp matheuscscp Oct 19, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change but I consider it very minor:

  • Released in Flux 2.9 (last release, too recent).
  • Sort of niche feature.
  • Chances of someone using it + relying on the cache metrics?

I will personally apologize to anyone we break with this.

@matheuscscp
matheuscscp force-pushed the rfc-0014-move-to-apis-crypto branch 8 times, most recently from 5d6ccbd to 52c3e73 Compare October 20, 2026 18:44
@matheuscscp
matheuscscp added this pull request to stack #1780 October 20, 2026 20:03
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
matheuscscp force-pushed the rfc-0014-move-to-apis-crypto branch from 52c3e73 to cd5ff79 Compare October 20, 2026 20:09

@stefanprodan stefanprodan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheuscscp
matheuscscp merged commit d0c2cf2 into main Oct 22, 2026
7 checks passed
@matheuscscp
matheuscscp deleted the rfc-0014-move-to-apis-crypto branch October 22, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Security related issues and pull requests enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants